026147a48

Rob Landley

2006-04-17

SOURCE BUG Duration: 30s

Subject

Patch from Tito to fix printing null and make output look like hdparm 6.3.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

miscutils/hdparm.c +5 -5

miscutils/hdparm.c+5 -5

@@ -291,8 +291,8 @@ static const char * const minor_str[] = { /* word 81 value: */
	"Reserved", /* 0x001a */
	"ATA/ATAPI-6 T13 1410D revision 2", /* 0x001b */
	"ATA/ATAPI-6 T13 1410D revision 1", /* 0x001c */
-	"reserved" /* 0x001d */
-	"reserved" /* 0x001e */
+	"reserved", /* 0x001d */
+	"reserved", /* 0x001e */
	"reserved" /* 0x001f-0xfffe*/
	};
	#endif
@@ -1427,10 +1427,10 @@ static void dump_identity (const struct hd_driveid *id)
	{
	printf("\n Drive conforms to: ");
	if_else_printf((id->minor_rev_num <= 31),"%s: ","unknown: ", minor_str[id->minor_rev_num]);
-	if (id->major_rev_num < 31)
-	{
+	if (id->major_rev_num != 0x0000 && /* NOVAL_0 */
+	id->major_rev_num != 0xFFFF) { /* NOVAL_1 */
	for (i=0; i <= 15; i++)
-	if_printf((id->major_rev_num & (1<<i))," %u", i);
+	if_printf((id->major_rev_num & (1<<i))," ATA/ATAPI-%u", i);
	}
	}
	#endif /* __NEW_HD_DRIVE_ID */