← Commit list

05965cbb7

Denys Vlasenko
Denys Vlasenko
2013-07-29
SUCCESS Duration: 182s

Subject

nc: remove unnecessary "errno = 0"

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/nc_bloaty.c+4 -5
@@ -613,7 +613,6 @@ static int readwrite(void)
while (fds_open) {
unsigned wretry = 8200; /* net-write sanity counter */
- errno = 0; /* clear from sleep, close, whatever */
ding2 = ding1; /* FD_COPY ain't portable... */
/* some systems, notably linux, crap into their select timers on return, so
we create a expendable copy and give *that* to select. */
@@ -696,9 +695,9 @@ Debug("got %d from the net, errno %d", rr, errno);
if (rr > 0) {
if (o_ofile) /* log the stdout */
oprint('<', (unsigned char *)np, rr);
- np += rr; /* fix up ptrs and whatnot */
+ np += rr;
rnleft -= rr;
- wrote_out += rr; /* global count */
+ wrote_out += rr; /* global count */
}
Debug("wrote %d to stdout, errno %d", rr, errno);
} /* rnleft */
@@ -713,7 +712,7 @@ Debug("wrote %d to stdout, errno %d", rr, errno);
oprint('>', (unsigned char *)zp, rr);
zp += rr;
rzleft -= rr;
- wrote_net += rr; /* global count */
+ wrote_net += rr; /* global count */
}
Debug("wrote %d to net, errno %d", rr, errno);
} /* rzleft */
@@ -730,7 +729,7 @@ Debug("wrote %d to net, errno %d", rr, errno);
}
goto shovel;
}
- } /* while ding1:netfd is open */
+ } /* while (fds_open) */
/* XXX: maybe want a more graceful shutdown() here, or screw around with
linger times?? I suspect that I don't need to since I'm always doing