07a637df4

Rob Landley

2006-04-01

SOURCE BUG Duration: 15s

Subject

Patch from KRONSTORFER Horst to Fix a size mismatch in ping, such as the 56/84 mismatch inthe following example: # ping -c 1 172.16.2.1 PING 172.16.2.1 (172.16.2.1): 56 data bytes 84 bytes from 172.16.2.1: icmp_seq=0 ttl=64 time=0.2 ms

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/ping.c +2 -2 networking/ping6.c +2 -2

networking/ping.c+2 -2

@@ -108,7 +108,7 @@ static void ping(const char *host)
	pkt->icmp_type = ICMP_ECHO;
	pkt->icmp_cksum = in_cksum((unsigned short *) pkt, sizeof(packet));

-	c = sendto(pingsock, packet, sizeof(packet), 0,
+	c = sendto(pingsock, packet, DEFDATALEN + ICMP_MINLEN, 0,
	(struct sockaddr *) &pingaddr, sizeof(struct sockaddr_in));

	if (c < 0 \|\| c != sizeof(packet))
@@ -202,7 +202,7 @@ static void sendping(int junk)
	{
	struct icmp *pkt;
	int i;
-	char packet[datalen + sizeof(struct icmp)];
+	char packet[datalen + ICMP_MINLEN];

	pkt = (struct icmp *) packet;

networking/ping6.c+2 -2

@@ -111,7 +111,7 @@ static void ping(const char *host)
	setsockopt(pingsock, SOL_RAW, IPV6_CHECKSUM, (char *) &sockopt,
	sizeof(sockopt));

-	c = sendto(pingsock, packet, sizeof(packet), 0,
+	c = sendto(pingsock, packet, DEFDATALEN + sizeof (struct icmp6_hdr), 0,
	(struct sockaddr *) &pingaddr, sizeof(struct sockaddr_in6));

	if (c < 0 \|\| c != sizeof(packet))
@@ -204,7 +204,7 @@ static void sendping(int junk)
	{
	struct icmp6_hdr *pkt;
	int i;
-	char packet[datalen + 8];
+	char packet[datalen + sizeof (struct icmp6_hdr)];

	pkt = (struct icmp6_hdr *) packet;