07e42dc05

Rob Landley

2005-09-17

SOURCE BUG Duration: 7s

Subject

Tito pointed out that if readlink doesn't have -f, there's no need to call the option parsing code at all.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

debianutils/readlink.c +6 -6

debianutils/readlink.c+6 -6

@@ -18,16 +18,16 @@
	int readlink_main(int argc, char **argv)
	{
	char *buf;
-	unsigned long opt = bb_getopt_ulflags(argc, argv,
-	ENABLE_FEATURE_READLINK_FOLLOW ? "f" : "");
+	unsigned long opt = ENABLE_FEATURE_READLINK_FOLLOW ?
+	bb_getopt_ulflags(argc, argv, "f") : 0;

-	if (optind + 1 != argc)
-	bb_show_usage();
+	if (argc != (ENABLE_FEATURE_READLINK_FOLLOW ? optind + 1 : 2))
+	bb_show_usage();

-	if (ENABLE_FEATURE_READLINK_FOLLOW && (opt & READLINK_FLAG_f))
+	if (opt & READLINK_FLAG_f)
	buf = realpath(argv[optind], NULL);
	else
-	buf = xreadlink(argv[optind]);
+	buf = xreadlink(argv[ENABLE_FEATURE_READLINK_FOLLOW ? optind : 1]);

	if (!buf)
	return EXIT_FAILURE;