← Commit list

08dfafc43

Denys Vlasenko

2017-07-15

SUCCESS Duration: 142s

Subject

fix more instances of ": $((a++))" in shell scripts

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

examples/mdev.conf.change_blockdev.sh +1 -1 examples/var_service/dhcp_if_pinger/run +1 -1 util-linux/mkfs_ext2_test.sh +6 -6

examples/mdev.conf.change_blockdev.sh+1 -1

@@ -14,7 +14,7 @@ env \| sort

	while sleep 1; test $cnt != 0; do
	echo "Trying to reread partition table on $DEVNAME ($cnt)"
-	: $((cnt--))
+	cnt=$((cnt-1))
	# If device node doesn't exist, it means the device was removed.
	# Stop trying.
	test -e "$DEVNAME" \|\| { echo "$DEVNAME doesn't exist, aborting"; exit 1; }

examples/var_service/dhcp_if_pinger/run+1 -1

@@ -30,7 +30,7 @@ test x"$router" != x"" \|\| exec env - sleep "$ping_time"
	failcnt=0
	while true; do
	ping $ping_opts "$router" && exec env - sleep "$ping_time"
-	: $((failcnt++))
+	failcnt=$((failcnt+1))
	msg "Failed to ping $router, fail count:$failcnt"
	test $failcnt -ge $max_fail && break
	env - sleep "$retry_time"

util-linux/mkfs_ext2_test.sh+6 -6

@@ -47,7 +47,7 @@ test_mke2fs() {
	kilobytes=60
	while true; do
	test_mke2fs \|\| exit 1
-	: $((kilobytes++))
+	kilobytes=$((kilobytes+1))
	test $kilobytes = 200 && break
	done

@@ -56,7 +56,7 @@ done
	kilobytes=$((1 * 8*1024 - 50))
	while true; do
	test_mke2fs \|\| exit 1
-	: $((kilobytes++))
+	kilobytes=$((kilobytes+1))
	test $kilobytes = $((1 * 8*1024 + 300)) && break
	done

@@ -65,7 +65,7 @@ done
	kilobytes=$((2 * 8*1024 - 50))
	while true; do
	test_mke2fs \|\| exit 1
-	: $((kilobytes++))
+	kilobytes=$((kilobytes+1))
	test $kilobytes = $((2 * 8*1024 + 400)) && break
	done

@@ -74,7 +74,7 @@ done
	kilobytes=$((3 * 8*1024 - 50))
	while true; do
	test_mke2fs \|\| exit 1
-	: $((kilobytes++))
+	kilobytes=$((kilobytes+1))
	test $kilobytes = $((3 * 8*1024 + 500)) && break
	done

@@ -83,7 +83,7 @@ done
	kilobytes=$((4 * 8*1024 - 50))
	while true; do
	test_mke2fs \|\| exit 1
-	: $((kilobytes++))
+	kilobytes=$((kilobytes+1))
	test $kilobytes = $((4 * 8*1024 + 600)) && break
	done

@@ -92,7 +92,7 @@ done
	kilobytes=$((5 * 8*1024 - 50))
	while true; do
	test_mke2fs \|\| exit 1
-	: $((kilobytes++))
+	kilobytes=$((kilobytes+1))
	test $kilobytes = $((5 * 8*1024 + 700)) && break
	done
	exit