← Commit list

0afdfdf64

Denis Vlasenko
Denis Vlasenko
2007-09-28
FAILED Duration: 15s

Subject

hdparm: paranoia-induced fix against theoretical div-by-0 case

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

miscutils/hdparm.c+2 -2
@@ -1378,8 +1378,8 @@ static void print_timing(unsigned m, unsigned elapsed_us)
printf("%5u MB in %u.%02u seconds = %u kB/s\n",
m, sec, hs,
- /* + 1 prevents div-by-0 */
- (unsigned) ((unsigned long long)m * (1024 * 1000000) / (elapsed_us + 1))
+ /* "| 1" prevents div-by-0 */
+ (unsigned) ((unsigned long long)m * (1024 * 1000000) / (elapsed_us | 1))
// ~= (m * 1024) / (elapsed_us / 1000000)
// = kb / elapsed_sec
);