0b1ff5a60

Rob Landley

2005-05-26

FAILED Duration: 36s

Subject

Tobias Krawutschke found a bug where the DHCP client would accept packets with the wrong ARP address, meaning we could easily get somebody else's IP. That is a bad thing, and this is the minimal two-line fix.

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/udhcp/dhcpc.c +3 -0

networking/udhcp/dhcpc.c+3 -0

@@ -439,6 +439,9 @@ int main(int argc, char *argv[])
	(unsigned long) packet.xid, xid);
	continue;
	}
+	/* Ignore packets that aren't for us */
+	if (memcmp(client_config.arp,packet.chaddr,6))
+	continue;

	if ((message = get_option(&packet, DHCP_MESSAGE_TYPE)) == NULL) {
	DEBUG(LOG_ERR, "couldnt get option from packet -- ignoring");