0bafd47e8

Rob Landley

2006-03-25

SOURCE BUG Duration: 8s

Subject

Stephane Billiart found an endianness bug in insmod.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

modutils/insmod.c +2 -7

modutils/insmod.c+2 -7

@@ -516,12 +516,6 @@ int delete_module(const char *);
	#include <elf.h>
	#include <endian.h>

-	#if BB_LITTLE_ENDIAN
-	# define ELFDATAM ELFDATA2LSB
-	#else
-	# define ELFDATAM ELFDATA2MSB
-	#endif
-
	#ifndef ElfW
	# if ELFCLASSM == ELFCLASS32
	# define ElfW(x) Elf32_ ## x
@@ -3331,7 +3325,8 @@ static struct obj_file obj_load(FILE fp, int loadprogbits)
	return NULL;
	}
	if (f->header.e_ident[EI_CLASS] != ELFCLASSM
-	\|\| f->header.e_ident[EI_DATA] != ELFDATAM
+	\|\| f->header.e_ident[EI_DATA] != (BB_BIG_ENDIAN
+	? ELFDATA2MSB : ELFDATA2LSB)
	\|\| f->header.e_ident[EI_VERSION] != EV_CURRENT
	\|\| !MATCH_MACHINE(f->header.e_machine)) {
	bb_error_msg("ELF file not for this architecture");