← Commit list

0e020d102

Eric Andersen
Eric Andersen
2004-10-13
FAILED Duration: 25s

Subject

Make certain clients of bb_make_directory default to honoring the user's umask

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/libunarchive/data_extract_all.c+1 -1
@@ -35,7 +35,7 @@ extern void data_extract_all(archive_handle_t *archive_handle)
if (archive_handle->flags & ARCHIVE_CREATE_LEADING_DIRS) {
char *name = bb_xstrdup(file_header->name);
- bb_make_directory (dirname(name), 0777, FILEUTILS_RECUR);
+ bb_make_directory (dirname(name), -1, FILEUTILS_RECUR);
free(name);
}
libbb/make_directory.c+8 -1
@@ -49,7 +49,14 @@ int bb_make_directory (char *path, long mode, int flags)
struct stat st;
mask = umask(0);
- umask(mask & ~0300);
+ if (mode == -1) {
+ umask(mask);
+ mode = (S_IXUSR | S_IXGRP | S_IXOTH |
+ S_IWUSR | S_IWGRP | S_IWOTH |
+ S_IRUSR | S_IRGRP | S_IROTH) & ~mask;
+ } else {
+ umask(mask & ~0300);
+ }
do {
c = 0;
miscutils/devfsd.c+1 -1
@@ -1547,7 +1547,7 @@ static int make_dir_tree (const char *path)
#ifdef CONFIG_DEBUG
msg_logger( NO_DIE, LOG_INFO, "make_dir_tree()\n");
#endif
- if (bb_make_directory( dirname((char *)path), S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH ,FILEUTILS_RECUR )==-1)
+ if (bb_make_directory( dirname((char *)path), -1, FILEUTILS_RECUR )==-1)
{
#ifdef CONFIG_DEBUG
msg_logger( NO_DIE, LOG_ERR, "make_dir_tree(): %s: %m\n", path);