← Commit list

0effc2410

Denis Vlasenko
Denis Vlasenko
2008-01-28
FAILED Duration: 21s

Subject

microcom: undo #define trick, gcc fails to take advantage of it

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

miscutils/microcom.c+3 -3
@@ -45,8 +45,8 @@ int microcom_main(int argc, char **argv)
{
struct pollfd pfd[2];
int nfd;
- //int sfd;
-#define sfd (pfd[0].fd)
+ int sfd;
+/* #define sfd (pfd[0].fd) - gcc 4.2.1 is still not smart enough */
char *device_lock_file;
const char *opt_s = "9600";
speed_t speed;
@@ -123,7 +123,7 @@ int microcom_main(int argc, char **argv)
goto restore0_close_unlock_and_exit;
// main loop: check with poll(), then read/write bytes across
- /* pfd[0].fd = sfd; - they are the same */
+ pfd[0].fd = sfd;
pfd[0].events = POLLIN;
pfd[1].fd = STDIN_FILENO;
pfd[1].events = POLLIN;