12abcb36c
Denis Vlasenko
2008-12-10
Subject
libiproute: fix buggy open check: s/if (fd)/if (fd >= 0)/ less: small optimization -15 bytes
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
miscutils/less.c+1 -3
| @@ -774,9 +774,7 @@ static void buffer_line(int linenum) | |
| static void open_file_and_read_lines(void) | |
| { | |
| if (filename) { | |
| - | int fd = xopen(filename, O_RDONLY); |
| - | dup2(fd, 0); |
| - | if (fd) close(fd); |
| + | xmove_fd(xopen(filename, O_RDONLY), STDIN_FILENO); |
| } else { | |
| /* "less" with no arguments in argv[] */ | |
| /* For status line only */ | |
networking/libiproute/ll_map.c+1 -1
| @@ -172,7 +172,7 @@ int xll_name_to_index(const char *const name) | |
| #endif | |
| sock_fd = socket(AF_INET, SOCK_DGRAM, 0); | |
| - | if (sock_fd) { |
| + | if (sock_fd >= 0) { |
| struct ifreq ifr; | |
| int tmp; | |