14d7065ef

Rob Landley

2006-06-18

SOURCE BUG Duration: 34s

Subject

Make this slightly more readable, and expose the hypocrasy of a comment that says "our implementation makes it impossible to use blocksizes smaller than 22 octets" right above a check for blocksize < 8.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/tftp.c +1 -5

networking/tftp.c+1 -5

@@ -38,10 +38,6 @@
	#define TFTP_TIMEOUT 5 /* seconds */
	#define TFTP_NUM_RETRIES 5 /* number of retries */

-	/* RFC2348 says between 8 and 65464 */
-	#define TFTP_OCTECTS_MIN 8
-	#define TFTP_OCTECTS_MAX 65464
-
	static const char * const MODE_OCTET = "octet";
	#define MODE_OCTET_LEN 6 /* sizeof(MODE_OCTET)*/

@@ -87,7 +83,7 @@ static int tftp_blocksize_check(int blocksize, int bufsize)
	*/

	if ((bufsize && (blocksize > bufsize)) \|\|
-	(blocksize < TFTP_OCTECTS_MIN) \|\| (blocksize > TFTP_OCTECTS_MAX)) {
+	(blocksize < 8) \|\| (blocksize > 65564)) {
	bb_error_msg("bad blocksize");
	return 0;
	}