164c5c80b

Rob Landley

2005-12-15

SOURCE BUG Duration: 15s

Subject

Eliminate unnecessary allocation from md5sum that was leaked without ever being used.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

coreutils/md5_sha1_sum.c +0 -9

coreutils/md5_sha1_sum.c+0 -9

@@ -142,15 +142,6 @@ static int hash_files(int argc, char **argv, const uint8_t hash_algo)
	} else
	#endif
	{
-	uint8_t hash_length;
-
-	if (hash_algo == HASH_MD5) {
-	hash_length = 16;
-	} else {
-	hash_length = 20;
-	}
-	hash_value = xmalloc(hash_length);
-
	while (optind < argc) {
	char *file_ptr = argv[optind++];