← Commit list

168f0ef8d

Denys Vlasenko
Denys Vlasenko
2017-07-21
SUCCESS Duration: 142s

Subject

udhcpc[6]: on log level 1, three messages about raw socket is overkill

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/udhcp/d6_dhcpc.c+2 -2
@@ -877,10 +877,10 @@ static int d6_raw_socket(int ifindex)
};
#endif
- log1("opening raw socket on ifindex %d", ifindex); //log2?
+ log2("opening raw socket on ifindex %d", ifindex);
fd = xsocket(PF_PACKET, SOCK_DGRAM, htons(ETH_P_IPV6));
- log1("got raw socket fd %d", fd); //log2?
+ log2("got raw socket fd %d", fd);
sock.sll_family = AF_PACKET;
sock.sll_protocol = htons(ETH_P_IPV6);
networking/udhcp/dhcpc.c+2 -2
@@ -1001,14 +1001,14 @@ static int udhcp_raw_socket(int ifindex)
int fd;
struct sockaddr_ll sock;
- log1("opening raw socket on ifindex %d", ifindex); //log2?
+ log2("opening raw socket on ifindex %d", ifindex);
fd = xsocket(PF_PACKET, SOCK_DGRAM, htons(ETH_P_IP));
/* ^^^^^
* SOCK_DGRAM: remove link-layer headers on input (SOCK_RAW keeps them)
* ETH_P_IP: want to receive only packets with IPv4 eth type
*/
- log1("got raw socket fd"); //log2?
+ log2("got raw socket fd");
sock.sll_family = AF_PACKET;
sock.sll_protocol = htons(ETH_P_IP);