17329745f

Bernhard Reutner-Fischer

2005-12-21

SOURCE BUG Duration: 10s

Subject

- fix check for group and user, remove some whitespace while at it.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

miscutils/makedevs.c +4 -4

miscutils/makedevs.c+4 -4

@@ -86,7 +86,7 @@ extern int makedevs_main(int argc, char **argv)
	int ret = EXIT_SUCCESS;

	unsigned long flags;
-	flags = bb_getopt_ulflags(argc, argv, "d:", &line);
+	flags = bb_getopt_ulflags(argc, argv, "d:", &line);
	if (line)
	table = bb_xfopen(line, "r");

@@ -138,9 +138,9 @@ extern int makedevs_main(int argc, char **argv)
	if (name[0] == '#') {
	continue;
	}
-
-	gid = group ? get_ug_id(group, bb_xgetgrnam) : getgid();
-	uid = user ? get_ug_id(user, bb_xgetpwnam) : getuid();
+
+	gid = (*group) ? get_ug_id(group, bb_xgetgrnam) : getgid();
+	uid = (*user) ? get_ug_id(user, bb_xgetpwnam) : getuid();
	full_name = concat_path_file(rootdir, name);

	if (type == 'd') {