← Commit list

173aa78bc

Denys Vlasenko
Denys Vlasenko
2013-06-28
SUCCESS Duration: 195s

Subject

pstree: fix theoretically unsafe code

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

procps/pstree.c+1 -1
@@ -349,7 +349,7 @@ static void dump_by_user(PROC *current, uid_t uid)
static void handle_thread(const char *comm, pid_t pid, pid_t ppid, uid_t uid)
{
char threadname[COMM_DISP_LEN + 1];
- sprintf(threadname, "{%.*s}", (int)sizeof(threadname) - 1, comm);
+ sprintf(threadname, "{%.*s}", (int)sizeof(threadname) - 3, comm);
add_proc(threadname, pid, ppid, uid/*, 1*/);
}
#endif