← Commit list

181f0773e

Glenn L McGrath
Glenn L McGrath
2004-02-23
FAILED Duration: 75s

Subject

bb_full_fd_action was incorrectly returning an error message causing major breaking.

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/copyfd.c+2 -2
@@ -50,8 +50,8 @@ static size_t bb_full_fd_action(int src_fd, int dst_fd, const size_t size)
}
read_actual = safe_read(src_fd, buffer, read_try);
- if ((read_actual > 0) && (dst_fd >= 0)) {
- if (bb_full_write(dst_fd, buffer, (size_t) read_actual) != read_actual) {
+ if (read_actual > 0) {
+ if ((dst_fd >= 0) && (bb_full_write(dst_fd, buffer, (size_t) read_actual) != read_actual)) {
bb_perror_msg(bb_msg_write_error); /* match Read error below */
break;
}