199501f2a

Rob Landley

2005-12-16

SOURCE BUG Duration: 10s

Subject

I screwed up the last commit: if dt is null when ENABLE_MULTIPLE_OPTIONS is off, we'd dereference the null. Oops.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

modutils/modprobe.c +8 -6

modutils/modprobe.c+8 -6

@@ -497,13 +497,15 @@ static struct dep_t *build_dep ( void )
	if ( strcmp ( dt-> m_name, mod ) == 0 )
	break;
	}
-	if ( ENABLE_FEATURE_MODPROBE_MULTIPLE_OPTIONS && dt ) {
-	char* new_opt = NULL;
-	while( ( opt = parse_command_string( opt, &new_opt ) ) ) {
-	dt-> m_options = append_option( dt-> m_options, new_opt );
+	if ( dt ) {
+	if ( ENABLE_FEATURE_MODPROBE_MULTIPLE_OPTIONS ) {
+	char* new_opt = NULL;
+	while( ( opt = parse_command_string( opt, &new_opt ) ) ) {
+	dt-> m_options = append_option( dt-> m_options, new_opt );
+	}
+	} else {
+	dt-> m_options = append_option( dt-> m_options, opt );
	}
-	} else {
-	dt-> m_options = append_option( dt-> m_options, opt );
	}
	}
	}