1c19deed1

Rob Landley

2006-01-12

SOURCE BUG Duration: 10s

Subject

The major:minor read from dev ends with \n, need to trim that.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/mdev.c +1 -1

util-linux/mdev.c+1 -1

@@ -42,7 +42,7 @@ static void make_device(char *path)
	fd = open(temp, O_RDONLY);
	len = read(fd, temp, PATH_MAX-1);
	if (len<1) goto end;
-	temp[len] = 0;
+	temp[--len] = 0; // remove trailing \n
	close(fd);

	/* Determine device name, type, major and minor */