1eef0c457

Mike Frysinger

2005-08-16

SOURCE BUG Duration: 5s

Subject

Bernhard Fischer says: use xmalloc() instead of malloc()

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/dpkg.c +1 -1 archival/libunarchive/decompress_unzip.c +1 -1 archival/rpm.c +1 -1

archival/dpkg.c+1 -1

@@ -1299,7 +1299,7 @@ static char *all_control_list(const char package_name)
	char **remove_files;

	/* Create a list of all /var/lib/dpkg/info/<package> files */
-	remove_files = malloc(sizeof(all_control_files));
+	remove_files = xmalloc(sizeof(all_control_files));
	while (all_control_files[i]) {
	remove_files[i] = xmalloc(strlen(package_name) + strlen(all_control_files[i]) + 21);
	sprintf(remove_files[i], "/var/lib/dpkg/info/%s.%s", package_name, all_control_files[i]);

archival/libunarchive/decompress_unzip.c+1 -1

@@ -176,7 +176,7 @@ static void make_gunzip_crc_table(void)

	/* initial shift register value */
	gunzip_crc = 0xffffffffL;
-	gunzip_crc_table = (unsigned int ) malloc(256 sizeof(unsigned int));
+	gunzip_crc_table = (unsigned int ) xmalloc(256 sizeof(unsigned int));

	/* Compute and print table of CRC's, five per line */
	for (i = 0; i < 256; i++) {

archival/rpm.c+1 -1

@@ -243,7 +243,7 @@ rpm_index *rpm_gettags(int fd, int num_tags)
	storepos = lseek(fd,0,SEEK_CUR) + header.entries * 16;

	while (header.entries--) {
-	tmpindex = tags[tagindex++] = malloc(sizeof(rpm_index));
+	tmpindex = tags[tagindex++] = xmalloc(sizeof(rpm_index));
	read(fd, tmpindex, sizeof(rpm_index));
	tmpindex->tag = ntohl(tmpindex->tag); tmpindex->type = ntohl(tmpindex->type); tmpindex->count = ntohl(tmpindex->count);
	tmpindex->offset = storepos + ntohl(tmpindex->offset);