← Commit list

20cc6d567

Rob Landley
Rob Landley
2006-09-12
SOURCE BUG Duration: 37s

Subject

Remove pointless "const". Bloatcheck says 0 bytes difference.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/gunzip.c+2 -2
@@ -48,8 +48,8 @@ int gunzip_main(int argc, char **argv)
do {
struct stat stat_buf;
- const char *old_path = argv[optind];
- const char *delete_path = NULL;
+ char *old_path = argv[optind];
+ char *delete_path = NULL;
char *new_path = NULL;
int src_fd;
int dst_fd;
archival/uncompress.c+2 -2
@@ -19,8 +19,8 @@ int uncompress_main(int argc, char **argv)
flags = bb_getopt_ulflags(argc, argv, "cf");
while (optind < argc) {
- const char *compressed_file = argv[optind++];
- const char *delete_path = NULL;
+ char *compressed_file = argv[optind++];
+ char *delete_path = NULL;
char *uncompressed_file = NULL;
int src_fd;
int dst_fd;
include/libbb.h+1 -1
@@ -189,7 +189,7 @@ extern FILE *xfopen(const char *path, const char *mode);
extern int bb_fclose_nonstdin(FILE *f);
extern void bb_fflush_stdout_and_exit(int retval) ATTRIBUTE_NORETURN;
-extern void xstat(const char * const filename, struct stat *buf);
+extern void xstat(char *filename, struct stat *buf);
extern int xsocket(int domain, int type, int protocol);
extern pid_t spawn(char **argv);
extern pid_t xspawn(char **argv);
libbb/xfuncs.c+1 -1
@@ -490,7 +490,7 @@ void xlisten(int s, int backlog)
#ifdef L_xstat
/* xstat() - a stat() which dies on failure with meaningful error message */
-void xstat(const char * const name, struct stat *stat_buf)
+void xstat(char *name, struct stat *stat_buf)
{
if (stat(name, stat_buf))
bb_perror_msg_and_die("Can't stat '%s'", name);
loginutils/deluser.c+2 -1
@@ -60,7 +60,8 @@ static void del_line_matching(const char *login, const char *filename)
if ((passwd = bb_wfopen(filename, "r"))) {
- xstat(filename, &statbuf);
+ // Remove pointless const.
+ xstat((char *)filename, &statbuf);
buffer = (char *) xmalloc(statbuf.st_size * sizeof(char));
fread(buffer, statbuf.st_size, sizeof(char), passwd);
fclose(passwd);
util-linux/swaponoff.c+1 -1
@@ -15,7 +15,7 @@
#include <sys/swap.h>
-static int swap_enable_disable(const char *device)
+static int swap_enable_disable(char *device)
{
int status;
struct stat st;