← Commit list

2324a7c9e

Rob Landley
Rob Landley
2006-03-22
SOURCE BUG Duration: 18s

Subject

Fix "seq 1 1".

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

coreutils/seq.c+2 -2
@@ -29,9 +29,9 @@ int seq_main(int argc, char **argv)
}
/* You should note that this is pos-5.0.91 semantics, -- FK. */
- if (first < last ? increment > 0 : increment < 0) {
+ if (first <= last ? increment > 0 : increment < 0) {
for (i = first;
- (first < last) ? (i <= last) : (i >= last);
+ (first <= last) ? (i <= last) : (i >= last);
i += increment)
{
printf("%g\n", i);
testsuite/seq.tests+1 -0
@@ -21,6 +21,7 @@ testing "seq (exit with error)" "seq 1 2 3 4 2> /dev/null || echo yes" \
testing "seq one argument" "seq 3" "1\n2\n3\n" "" ""
testing "seq two arguments" "seq 5 7" "5\n6\n7\n" "" ""
testing "seq two arguments reversed" "seq 7 5" "" "" ""
+testing "seq two arguments equal" "seq 3 3" "3\n" "" ""
testing "seq count up by 2" "seq 4 2 8" "4\n6\n8\n" "" ""
testing "seq count down by 2" "seq 8 -2 4" "8\n6\n4\n" "" ""
testing "seq count wrong way #1" "seq 4 -2 8" "" "" ""