243d1757d
Denys Vlasenko
2010-07-04
Subject
remove some dead assignments, add a TODO comment
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
archival/libunarchive/data_extract_all.c+1 -0
| @@ -127,6 +127,7 @@ void FAST_FUNC data_extract_all(archive_handle_t *archive_handle) | |
| break; | |
| case S_IFLNK: | |
| /* Symlink */ | |
| + | //TODO: what if file_header->link_target == NULL (say, corrupted tarball?) |
| res = symlink(file_header->link_target, file_header->name); | |
| if ((res == -1) | |
| && !(archive_handle->ah_flags & ARCHIVE_EXTRACT_QUIET) | |
editors/vi.c+0 -1
| @@ -2385,7 +2385,6 @@ static int file_write(char *fn, char *first, char *last) | |
| status_line_bold("No current filename"); | |
| return -2; | |
| } | |
| - | charcnt = 0; |
| /* By popular request we do not open file with O_TRUNC, | |
| * but instead ftruncate() it _after_ successful write. | |
| * Might reduce amount of data lost on power fail etc. | |
networking/udhcp/dhcprelay.c+1 -2
| @@ -175,7 +175,6 @@ static void pass_to_server(struct dhcp_packet *p, int packet_len, int client, in | |
| struct sockaddr_in *client_addr, struct sockaddr_in *server_addr) | |
| { | |
| int res, type; | |
| - | struct xid_item *item; |
| /* check packet_type */ | |
| type = get_dhcp_packet_type(p); | |
| @@ -187,7 +186,7 @@ static void pass_to_server(struct dhcp_packet *p, int packet_len, int client, in | |
| } | |
| /* create new xid entry */ | |
| - | item = xid_add(p->xid, client_addr, client); |
| + | xid_add(p->xid, client_addr, client); |
| /* forward request to LAN (server) */ | |
| errno = 0; | |