2584e9b39

Rob Landley

2006-05-03

SOURCE BUG Duration: 42s

Subject

Remove HDIO_GETGEO_BIG which is dead (removed from 2.6) and was pointless back in 2.4 (it fetched the same hd_geometry struct only with uint cylinders instead of ushort cylinders: nothing that big has ever accurately reported gemoetry, it's all LBA.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

miscutils/hdparm.c +4 -12

miscutils/hdparm.c+4 -12

@@ -2143,21 +2143,13 @@ static void process_dev(char *devname)
	}
	if (verbose \|\| get_geom)
	{
-	static const char msg[] = " geometry = %u/%u/%u, sectors = %ld, start = %ld\n";
-	static struct hd_geometry g;
-	#ifdef HDIO_GETGEO_BIG
-	static struct hd_big_geometry bg;
-	#endif
-
	if (!bb_ioctl(fd, BLKGETSIZE, &parm, "BLKGETSIZE"))
	{
-	#ifdef HDIO_GETGEO_BIG
-	if (!bb_ioctl(fd, HDIO_GETGEO_BIG, &bg, "HDIO_GETGEO_BIG"))
-	printf(msg, bg.cylinders, bg.heads, bg.sectors, parm, bg.start);
-	else
-	#endif
+	struct hd_geometry g;
+
	if (!bb_ioctl(fd, HDIO_GETGEO, &g, "HDIO_GETGEO"))
-	printf(msg, g.cylinders, g.heads, g.sectors, parm, g.start);
+	printf(" geometry = %u/%u/%u, sectors = %ld, start = %ld\n",
+	g.cylinders, g.heads, g.sectors, parm, g.start);
	}
	}
	#ifdef HDIO_DRIVE_CMD