27d07c9ce
Rob Landley
2006-08-04
Subject
Now that we have xopen3(), it's just plain unclean to have xopen() with O_CREAT. Two users are still doing it (and thus getting permissions 777), I'm not sure what permissions they should be using but here they are changed to xopen3(). This costs us a dozen or so bytes, but removing the 777 from x
SOURCE BUG
This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
archival/unzip.c+1 -1
| @@ -333,7 +333,7 @@ int unzip_main(int argc, char **argv) | |
| overwrite = o_always; | |
| case 'y': /* Open file and fall into unzip */ | |
| unzip_create_leading_dirs(dst_fn); | |
| - | dst_fd = xopen(dst_fn, O_WRONLY | O_CREAT); |
| + | dst_fd = xopen(dst_fn, O_WRONLY | O_CREAT, 777); |
| case -1: /* Unzip */ | |
| if (verbosity == v_normal) { | |
| printf(" inflating: %s\n", dst_fn); | |
networking/ftpgetput.c+1 -1
| @@ -166,7 +166,7 @@ static int ftp_receive(ftp_host_info_t *server, FILE *control_stream, | |
| if (do_continue) { | |
| fd_local = xopen(local_path, O_APPEND | O_WRONLY); | |
| } else { | |
| - | fd_local = xopen(local_path, O_CREAT | O_TRUNC | O_WRONLY); |
| + | fd_local = xopen3(local_path, O_CREAT | O_TRUNC | O_WRONLY, 777); |
| } | |
| } | |