29ba9796b

Rob Landley

2006-04-17

SOURCE BUG Duration: 32s

Subject

Robert Eggers noticed that nfsmount would sometimes incorrectly return success.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/nfsmount.c +2 -6

util-linux/nfsmount.c+2 -6

@@ -572,13 +572,9 @@ int nfsmount(const char spec, const char node, int *flags,
	if (nfs_mount_version >= 3)
	data.flags \|= (nolock ? NFS_MOUNT_NONLM : 0);
	#endif
-	if (nfsvers > MAX_NFSPROT) {
+	if (nfsvers > MAX_NFSPROT \|\| mountvers > MAX_NFSPROT) {
	bb_error_msg("NFSv%d not supported!", nfsvers);
-	return 0;
-	}
-	if (mountvers > MAX_NFSPROT) {
-	bb_error_msg("NFSv%d not supported!", nfsvers);
-	return 0;
+	return 1;
	}
	if (nfsvers && !mountvers)
	mountvers = (nfsvers < 3) ? 1 : nfsvers;