← Commit list

2ab994f70

Denys Vlasenko
Denys Vlasenko
2018-04-06
SUCCESS Duration: 144s

Subject

placate gcc-8.0.1 warnings

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/dump.c+3 -3
@@ -464,11 +464,9 @@ static const char conv_str[] ALIGN1 =
"\v" "\\""v""\0"
;
-
static void conv_c(PR *pr, unsigned char *p)
{
const char *str = conv_str;
- char buf[10];
do {
if (*p == *str) {
@@ -482,7 +480,9 @@ static void conv_c(PR *pr, unsigned char *p)
*pr->cchar = 'c';
printf(pr->fmt, *p);
} else {
- sprintf(buf, "%03o", (int) *p);
+ char buf[4];
+ /* gcc-8.0.1 needs lots of casts to shut up */
+ sprintf(buf, "%03o", (unsigned)(uint8_t)*p);
str = buf;
strpr:
*pr->cchar = 's';
runit/sv.c+2 -0
@@ -222,6 +222,7 @@ struct globals {
#define str_equal(s,t) (strcmp((s), (t)) == 0)
+#if ENABLE_SV || ENABLE_SVC
static void fatal_cannot(const char *m1) NORETURN;
static void fatal_cannot(const char *m1)
{
@@ -688,6 +689,7 @@ static int sv(char **argv)
}
return rc > 99 ? 99 : rc;
}
+#endif
#if ENABLE_SV
int sv_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;