2f86d13df
Denis Vlasenko
2008-07-29
Subject
libbb: dump: do not use uninitialized memory. close bug 4364.
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
libbb/dump.c+3 -4
| @@ -376,17 +376,16 @@ static unsigned char *get(priv_dumper_t *dumper) | |
| { | |
| int n; | |
| int need, nread; | |
| - | unsigned char *tmpp; |
| int blocksize = dumper->blocksize; | |
| if (!dumper->get__curp) { | |
| dumper->address = (off_t)0; /*DBU:[[email protected]] initialize,initialize..*/ | |
| dumper->get__curp = xmalloc(blocksize); | |
| - | dumper->get__savp = xmalloc(blocksize); |
| + | dumper->get__savp = xzalloc(blocksize); /* need to be initialized */ |
| } else { | |
| - | tmpp = dumper->get__curp; |
| + | unsigned char *tmp = dumper->get__curp; |
| dumper->get__curp = dumper->get__savp; | |
| - | dumper->get__savp = tmpp; |
| + | dumper->get__savp = tmp; |
| dumper->savaddress += blocksize; | |
| dumper->address = dumper->savaddress; | |
| } | |