← Commit list

319e20b56

Denys Vlasenko
Denys Vlasenko
2021-08-15
SUCCESS Duration: 152s

Subject

taskset: disallow "taskset -p 0"

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/taskset.c+2 -2
@@ -218,7 +218,7 @@ static int process_pid_str(const char *pid_str, unsigned opts, char *aff)
ul *mask;
unsigned mask_size_in_bytes;
const char *current_new;
- pid_t pid = xatoi_positive(pid_str);
+ pid_t pid = !pid_str ? 0 : xatou_range(pid_str, 1, INT_MAX); /* disallow "0": "taskset -p 0" should fail */
mask_size_in_bytes = SZOF_UL;
current_new = "current";
@@ -343,7 +343,7 @@ int taskset_main(int argc UNUSED_PARAM, char **argv)
/* <aff> <cmd...> */
if (!*argv)
bb_show_usage();
- process_pid_str("0", opts, aff);
+ process_pid_str(NULL, opts, aff);
BB_EXECVP_or_die(argv);
}