335766602
Denys Vlasenko
2018-06-28
Subject
testsuite/mount.tests: fix false positive
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
libbb/loop.c+4 -0
| @@ -106,6 +106,10 @@ int FAST_FUNC set_loop(char **device, const char *file, unsigned long long offse | |
| return -errno; | |
| } | |
| + | //TODO: use LOOP_CTL_GET_FREE instead of trying every loopN in sequence? a-la: |
| + | // fd = open("/dev/loop-control", O_RDWR); |
| + | // loopN = ioctl(fd, LOOP_CTL_GET_FREE); |
| + | // |
| /* Find a loop device. */ | |
| try = *device ? *device : dev; | |
| /* 1048575 (0xfffff) is a max possible minor number in Linux circa 2010 */ | |
testsuite/mount.tests+2 -0
| @@ -10,9 +10,11 @@ test "`id -u`" = 0 || { | |
| exit 0 | |
| } | |
| + | # Without MOUNT_LOOP_CREATE, the test will fail if /dev/loopN's do not exist |
| if test x"$CONFIG_MKFS_MINIX" != x"y" \ | |
| || test x"$CONFIG_FEATURE_MINIX2" != x"y" \ | |
| || test x"$CONFIG_FEATURE_MOUNT_LOOP" != x"y" \ | |
| + | || test x"$CONFIG_FEATURE_MOUNT_LOOP_CREATE" != x"y" \ |
| || test x"$CONFIG_FEATURE_MOUNT_FLAGS" != x"y" \ | |
| || test x"$CONFIG_FEATURE_DEVFS" = x"y" \ | |
| ; then | |