37adefc67

Rob Landley

2005-09-01

SOURCE BUG Duration: 6s

Subject

Off by one error in max_leases sanity check. Bug 349, apparently.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/udhcp/dhcpd.c +1 -1

networking/udhcp/dhcpd.c+1 -1

@@ -88,7 +88,7 @@ int main(int argc, char *argv[])
	else server_config.lease = LEASE_TIME;

	/* Sanity check */
-	num_ips = ntohl(server_config.end) - ntohl(server_config.start);
+	num_ips = ntohl(server_config.end) - ntohl(server_config.start) + 1;
	if (server_config.max_leases > num_ips) {
	LOG(LOG_ERR, "max_leases value (%lu) not sane, "
	"setting to %lu instead",