3d9b965b4

Denys Vlasenko

2025-07-06

SOURCE BUG Duration: 108s

Subject

libbb/yescrypt: remove unused yescrypt_binary_t

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): libbb/yescrypt eklenirken (2025-07-06 - 2025-07-07 arasi) once unutulan kaynak dosyalari (pw_encrypt_yes.c, hash_sha256_block.c, pw_ascii64.c), ardindan 64-bit'te derlenmeyen bir 'buflen' degiskeni (alg-yescrypt-kdf.c) vardi - busybox'in kendi kodundaki gercek hatalar (e5d3a8763 ile duzeltildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/yescrypt/alg-yescrypt.h +1 -10

libbb/yescrypt/alg-yescrypt.h+1 -10

@@ -112,15 +112,6 @@ typedef struct {
	uint64_t NROM;
	} yescrypt_params_t;

-	/**
-	* A 256-bit yescrypt hash, or a hash encryption key (which may itself have
-	* been derived as a yescrypt hash of a human-specified key string).
-	*/
-	typedef union {
-	unsigned char uc[32];
-	uint64_t u64[4];
-	} yescrypt_binary_t;
-
	/* How many chars base-64 encoded bytes require? */
	#define BYTES2CHARS(bytes) ((((bytes) * 8) + 5) / 6)
	/* The /etc/passwd-style hash is "<prefix>$<hash><NUL>" */
@@ -131,7 +122,7 @@ typedef union {
	*/
	#define PREFIX_LEN (3 + 8 * 6 + 1 + BYTES2CHARS(32))

-	#define HASH_SIZE sizeof(yescrypt_binary_t) /* bytes */
+	#define HASH_SIZE 32
	#define HASH_LEN BYTES2CHARS(HASH_SIZE)

	/**