3fc4ad147

Rob Landley

2005-11-04

SOURCE BUG Duration: 7s

Subject

Fix bug 424: doing full_read breaks things like cat which should return a chunk of data when they get it and not block until they've buffered 4k.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/copyfd.c +1 -1

libbb/copyfd.c+1 -1

@@ -33,7 +33,7 @@ static ssize_t bb_full_fd_action(int src_fd, int dst_fd, size_t size)
	while (!size \|\| total < size)
	{
	ssize_t wrote, xread = (size && size < BUFSIZ) ? size : BUFSIZ;
-	xread = bb_full_read(src_fd, buffer, xread);
+	xread = safe_read(src_fd, buffer, xread);
	if (xread > 0) {
	/* A -1 dst_fd means we need to fake it... */
	wrote = (dst_fd < 0) ? xread : bb_full_write(dst_fd, buffer, xread);