42f67026a

Bernhard Reutner-Fischer

2006-09-21

SOURCE BUG Duration: 43s

Subject

- silence gcc warning about a funcptr possibly being used uninitialized. This is a perfect example on where we should NOT care if the functor is not initialized since the result will not be what the user may expect. Safe bet would be to init to NULL, but let's try normal uu for good measure. -

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

coreutils/uudecode.c +2 -2

coreutils/uudecode.c+2 -2

@@ -36,7 +36,7 @@ static int read_stduu(FILE src_stream, FILE dst_stream)
	}

	line_ptr++;
-	/* Tolerate an overly long line to acomadate a possible exta '`' */
+	/* Tolerate an overly long line to accomodate a possible exta '`' */
	if (strlen(line_ptr) < (size_t)length) {
	bb_error_msg_and_die("Short file");
	}
@@ -125,7 +125,7 @@ static int read_base64(FILE src_stream, FILE dst_stream)

	int uudecode_main(int argc, char **argv)
	{
-	int (decode_fn_ptr) (FILE src, FILE * dst);
+	int (decode_fn_ptr)(FILE src, FILE * dst) = read_stduu; /* silence gcc */
	FILE *src_stream;
	char *outname = NULL;
	char *line;