44e216f26

Bernhard Reutner-Fischer

2006-06-10

SOURCE BUG Duration: 55s

Subject

- use bb_xchdir instead of ignoring eventual errors of chdir Thanks to Erik Hovland

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/dpkg_deb.c +2 -2 archival/rpm.c +1 -1

archival/dpkg_deb.c+2 -2

@@ -89,8 +89,8 @@ int dpkg_deb_main(int argc, char **argv)
	extract_dir = argv[optind];
	}
	if (extract_dir) {
-	mkdir(extract_dir, 0777);
-	chdir(extract_dir); /* error check? */
+	mkdir(extract_dir, 0777); /* bb_make_directory(extract_dir, 0777, 0) */
+	bb_xchdir(extract_dir);
	}
	unpack_ar_archive(ar_archive);

archival/rpm.c+1 -1

@@ -198,7 +198,7 @@ void extract_cpio_gz(int fd) {
	bb_error_msg_and_die("Invalid gzip magic");
	}
	check_header_gzip(archive_handle->src_fd);
-	chdir("/"); // Install RPM's to root
+	bb_xchdir("/"); // Install RPM's to root

	archive_handle->src_fd = open_transformer(archive_handle->src_fd, inflate_gunzip);
	archive_handle->offset = 0;