450196c11
Denis Vlasenko
2007-03-28
Subject
ps: work around libc bug: printf("%.*s\n", MAX_INT, buffer)
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
libbb/xfuncs.c+3 -3
| @@ -253,9 +253,9 @@ void smart_ulltoa5(unsigned long long ul, char buf[5]) | |
| buf[4] = '\0'; | |
| } | |
| - | // Convert unsigned integer to ascii, writing into supplied buffer. A |
| - | // truncated result is always null terminated (unless buflen is 0), and |
| - | // contains the first few digits of the result ala strncpy. |
| + | // Convert unsigned integer to ascii, writing into supplied buffer. |
| + | // A truncated result contains the first few digits of the result ala strncpy. |
| + | // Returns a pointer past last generated digit, does _not_ store NUL. |
| void BUG_sizeof_unsigned_not_4(void); | |
| char *utoa_to_buf(unsigned n, char *buf, unsigned buflen) | |
| { | |
procps/ps.c+3 -1
| @@ -262,7 +262,9 @@ int ps_main(int argc, char **argv) | |
| parse_o(default_o); | |
| post_process(); | |
| - | terminal_width = INT_MAX; |
| + | /* Was INT_MAX, but some libc's go belly up with printf("%.*s") |
| + | * and such large widths */ |
| + | terminal_width = 30000; |
| if (isatty(1)) { | |
| get_terminal_width_height(1, &terminal_width, NULL); | |
| terminal_width--; | |