← Commit list

452cc1d9b

Denys Vlasenko

2017-08-14

SUCCESS Duration: 144s

Subject

ash: [PARSER] Catch variable length expansions on non-existant specials

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

shell/ash.c +9 -3

shell/ash.c+9 -3

@@ -12119,7 +12119,7 @@ parsesub: {
	STPUTC(c, out);
	c = pgetc_eatbnl();
	} while (isdigit(c));
-	} else if (is_special(c)) {
+	} else {
	/* $[{[#]]<specialchar>[}] */
	int cc = c;

@@ -12137,10 +12137,16 @@ parsesub: {
	cc = '#';
	}
	}
+
+	if (!is_special(cc)) {
+	if (subtype == VSLENGTH)
+	subtype = 0;
+	goto badsub;
+	}
+
	USTPUTC(cc, out);
-	} else {
-	goto badsub;
	}
+
	if (c != '}' && subtype == VSLENGTH) {
	/* ${#VAR didn't end with } */
	goto badsub;