49159c7f9

Rob Landley

2006-05-05

SOURCE BUG Duration: 45s

Subject

Patch from Jason Schoon to make mount -a not abort on the first failure.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/mount.c +6 -4

util-linux/mount.c+6 -4

@@ -533,11 +533,13 @@ int mount_main(int argc, char **argv)

	// Mount this thing.

-	rc = singlemount(mtcur);
-	if (rc) {
+	if (singlemount(mtcur)) {
	// Don't whine about already mounted fs when mounting all.
-	if (errno == EBUSY) rc = 0;
-	else break;
+	// Note: we should probably change return value to indicate
+	// failure, without causing a duplicate error message.
+	if (errno != EBUSY) bb_perror_msg("Mounting %s on %s failed",
+	mtcur->mnt_fsname, mtcur->mnt_dir);
+	rc = 0;
	}
	}
	}