← Commit list

493829207

Denis Vlasenko
Denis Vlasenko
2008-07-08
FAILED Duration: 22s

Subject

ifupdown: /etc/network/interfaces can have comments with leading blanks

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/ifupdown.c+2 -2
@@ -675,7 +675,7 @@ static struct interfaces_file_t *read_interfaces(const char *filename)
* the last character a backslash.
*
* Seen elsewhere in example config file:
- * A "#" character in the very first column makes the rest of the line
+ * A first non-blank "#" character makes the rest of the line
* be ignored. Blank lines are ignored. Lines may be indented freely.
* A "\" character at the very end of the line indicates the next line
* should be treated as a continuation of the current one.
@@ -711,7 +711,7 @@ static struct interfaces_file_t *read_interfaces(const char *filename)
#endif
rest_of_line = buf;
first_word = next_word(&rest_of_line);
- if (!first_word || *buf == '#') {
+ if (!first_word || *first_word == '#') {
free(buf);
continue; /* blank/comment line */
}