4bdc914ff
Denys Vlasenko
2019-01-06
Subject
build system: fix compiler warnings
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
Config.in +1 -1scripts/basic/split-include.c +2 -1scripts/kconfig/conf.c +4 -2scripts/kconfig/lxdialog/lxdialog.c +1 -1scripts/kconfig/mconf.c +5 -2
Config.in+1 -1
| @@ -12,7 +12,7 @@ config HAVE_DOT_CONFIG | |
| menu "Settings" | |
| config DESKTOP | |
| - | bool "Enable compatibility for full-blown desktop systems" |
| + | bool "Enable compatibility for full-blown desktop systems (8kb)" |
| default y | |
| help | |
| Enable applet options and features which are not essential. | |
scripts/basic/split-include.c+2 -1
| @@ -131,7 +131,8 @@ int main(int argc, const char * argv []) | |
| is_same = 0; | |
| if ((fp_target = fopen(ptarget, "r")) != NULL) | |
| { | |
| - | fgets(old_line, buffer_size, fp_target); |
| + | if (!fgets(old_line, buffer_size, fp_target)) |
| + | ERROR_EXIT(ptarget); |
| if (fclose(fp_target) != 0) | |
| ERROR_EXIT(ptarget); | |
| if (!strcmp(line, old_line)) | |
scripts/kconfig/conf.c+4 -2
| @@ -142,7 +142,8 @@ static void conf_askvalue(struct symbol *sym, const char *def) | |
| check_stdin(); | |
| case ask_all: | |
| fflush(stdout); | |
| - | fgets(line, 128, stdin); |
| + | if (!fgets(line, 128, stdin)) |
| + | exit(1); |
| return; | |
| case set_default: | |
| printf("%s\n", def); | |
| @@ -390,7 +391,8 @@ static int conf_choice(struct menu *menu) | |
| check_stdin(); | |
| case ask_all: | |
| fflush(stdout); | |
| - | fgets(line, 128, stdin); |
| + | if (!fgets(line, 128, stdin)) |
| + | exit(1); |
| strip(line); | |
| if (line[0] == '?') { | |
| printf("\n%s\n", menu->sym->help ? | |
scripts/kconfig/lxdialog/lxdialog.c+1 -1
| @@ -189,7 +189,7 @@ int j_inputbox(const char *t, int ac, const char *const *av) | |
| int ret = dialog_inputbox(t, av[2], atoi(av[3]), atoi(av[4]), | |
| ac == 6 ? av[5] : (char *)NULL); | |
| if (ret == 0) | |
| - | fprintf(stderr, dialog_input_result); |
| + | fprintf(stderr, "%s", dialog_input_result); |
| return ret; | |
| } | |
scripts/kconfig/mconf.c+5 -2
| @@ -482,7 +482,8 @@ static int exec_conf(void) | |
| *argptr++ = NULL; | |
| - | pipe(pipefd); |
| + | if (pipe(pipefd)) |
| + | _exit(EXIT_FAILURE); |
| pid = fork(); | |
| if (pid == 0) { | |
| sigprocmask(SIG_SETMASK, &osset, NULL); | |
| @@ -846,9 +847,11 @@ static void conf(struct menu *menu) | |
| static void show_textbox(const char *title, const char *text, int r, int c) | |
| { | |
| int fd; | |
| + | int len = strlen(text); |
| fd = creat(".help.tmp", 0777); | |
| - | write(fd, text, strlen(text)); |
| + | if (write(fd, text, len) != len) |
| + | exit(1); |
| close(fd); | |
| show_file(".help.tmp", title, r, c); | |
| unlink(".help.tmp"); | |