4cb035dd2

Rob Landley

2006-09-05

SOURCE BUG Duration: 48s

Subject

Vladimir Dronnikov (ybrnj80 at yandex dot ru) pointed out that my cleanup of his code introduced a bug (an extra backslash in the CIFS mount string).

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/mount.c +3 -3

util-linux/mount.c+3 -3

@@ -253,8 +253,8 @@ static int mount_it_now(struct mntent mp, int vfsflags, char filteropts)
	return rc;
	}

-	// Mount one directory. Handles CIFS, NFS, loopback, autobind, and filesystem type
-	// detection. Returns 0 for success, nonzero for failure.
+	// Mount one directory. Handles CIFS, NFS, loopback, autobind, and filesystem
+	// type detection. Returns 0 for success, nonzero for failure.

	static int singlemount(struct mntent *mp, int ignore_busy)
	{
@@ -301,7 +301,7 @@ static int singlemount(struct mntent *mp, int ignore_busy)

	// compose new unc '\\server-ip\share'

-	s = xasprintf("\\\\%s\\%s",ip+3,strchr(mp->mnt_fsname+2,'\\'));
+	s = xasprintf("\\\\%s%s",ip+3,strchr(mp->mnt_fsname+2,'\\'));
	if (ENABLE_FEATURE_CLEAN_UP) free(mp->mnt_fsname);
	mp->mnt_fsname = s;