4e486a5d0

Eric Andersen

2003-01-12

SOURCE BUG Duration: 2s

Subject

Kiss Gabor noticed that ping compiled without BB_FEATURE_FANCY_PING would return 0 instead of EXIT_FAILURE when no response was received.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): sysdeps/linux/Config.in "fileutils/Config.in" dosyasini kaynak gosteriyor ama bu dosya repoda hic var olmadi (2002-12-05 - 2003-02-15 arasi orijinal yazar hatasi, 3238ea167 ile duzeltildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Debian 14.2.0-19) 14.2.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/ping.c +2 -2 networking/ping6.c +6 -7

networking/ping.c+2 -2

@@ -1,6 +1,6 @@
	/* vi: set sw=4 ts=4: */
	/*
-	* $Id: ping.c,v 1.52 2002/06/06 11:47:00 andersen Exp $
+	* $Id: ping.c,v 1.53 2003/01/12 06:08:33 andersen Exp $
	* Mini ping implementation for busybox
	*
	* Copyright (C) 1999 by Randolph Chung <[email protected]>
@@ -179,7 +179,7 @@ static char *hostname = NULL;
	static void noresp(int ign)
	{
	printf("No response from %s\n", hostname);
-	exit(0);
+	exit(EXIT_FAILURE);
	}

	static void ping(const char *host)

networking/ping6.c+6 -7

@@ -1,6 +1,6 @@
	/* vi: set sw=4 ts=4: */
	/*
-	* $Id: ping6.c,v 1.2 2002/11/26 03:03:41 bug1 Exp $
+	* $Id: ping6.c,v 1.3 2003/01/12 06:08:33 andersen Exp $
	* Mini ping implementation for busybox
	*
	* Copyright (C) 1999 by Randolph Chung <[email protected]>
@@ -77,6 +77,11 @@ static void ping(const char *host);

	/* simple version */
	#ifndef CONFIG_FEATURE_FANCY_PING6
+	void noresp(int ign)
+	{
+	printf("No response from %s\n", h->h_name);
+	exit(EXIT_FAILURE);
+	}

	static void ping(const char *host)
	{
@@ -87,12 +92,6 @@ static void ping(const char *host)
	int sockopt;
	char packet[DEFDATALEN + MAXIPLEN + MAXICMPLEN];

-	void noresp(int ign)
-	{
-	printf("No response from %s\n", h->h_name);
-	exit(0);
-	}
-
	pingsock = create_icmp6_socket();

	memset(&pingaddr, 0, sizeof(struct sockaddr_in));