4ee2eee2f

Mike Frysinger

2005-11-15

SOURCE BUG Duration: 7s

Subject

Quote the user we pass to addgroup so funky chars are preserved. Fix by dragan_marinkovic in Bug 544

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

loginutils/adduser.c +1 -1

loginutils/adduser.c+1 -1

@@ -117,7 +117,7 @@ static void addgroup_wrapper(const char *login, gid_t gid)
	{
	char *cmd;

-	cmd = bb_xasprintf("addgroup -g %d %s", gid, login);
+	cmd = bb_xasprintf("addgroup -g %d \"%s\"", gid, login);
	system(cmd);
	free(cmd);
	}