533320c65

Rob Landley

2006-07-31

SOURCE BUG Duration: 38s

Subject

1) ifeq is make syntax, #ifeq is a make comment. 2) The check_cc macros should probably all have the same number of arguments. 3) Move the -Werror into the gcc 4.0 on i386 test, because gcc 4.1 is broken and produces warnings for things that provably aren't incorrect.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

Rules.mak +10 -7

Rules.mak+10 -7

@@ -166,16 +166,17 @@ LD_END_GROUP:= -Wl,--end-group
	endif

	CHECKED_LDFLAGS := $(call check_ld,$(LD),--warn-common,)
+	#CHECKED_LDFLAGS := $(call check_ld,$(LD),-static-libgcc,)

	# Pin CHECKED_CFLAGS with := so it's only evaluated once.
	CHECKED_CFLAGS:=$(call check_cc,$(CC),-Wall,)
-	CHECKED_CFLAGS+=$(call check_cc,$(HOSTCC),-Werror,)
	CHECKED_CFLAGS+=$(call check_cc,$(CC),-Wstrict-prototypes,)
	CHECKED_CFLAGS+=$(call check_cc,$(CC),-Wshadow,)
	CHECKED_CFLAGS+=$(call check_cc,$(CC),-funsigned-char,)
	CHECKED_CFLAGS+=$(call check_cc,$(CC),-mmax-stack-frame=256,)
-	CHECKED_CFLAGS+=$(call check_cc,$(CC),-fno-builtin-strlen)
-	CHECKED_CFLAGS+=$(call check_cc,$(CC),-finline-limit=0)
+	CHECKED_CFLAGS+=$(call check_cc,$(CC),-fno-builtin-strlen,)
+	CHECKED_CFLAGS+=$(call check_cc,$(CC),-finline-limit=0,)
+	CHECKED_CFLAGS+=$(call check_cc,$(CC),-static-libgcc,)

	# Preemptively pin this too.
	PROG_CFLAGS:=
@@ -216,11 +217,13 @@ endif
	ifeq ($(strip $(TARGET_ARCH)),i386)
	OPTIMIZATION+=$(call check_cc,$(CC),-march=i386,)
	# gcc-4.0 and older seem to benefit from these
-	#ifneq ($(strip $(shell [ $(CC_MAJOR) -ge 4 -a $(CC_MINOR) -ge 1 ] ; echo $$?)),0)
+	ifneq ($(strip $(shell [ $(CC_MAJOR) -ge 4 -a $(CC_MINOR) -ge 1 ] ; echo $$?)),0)
	OPTIMIZATION+=$(call check_cc,$(CC),-mpreferred-stack-boundary=2,)
-	OPTIMIZATION+=$(call check_cc,$(CC),-falign-functions=1 -falign-jumps=1 -falign-loops=1,\
-	-malign-functions=0 -malign-jumps=0 -malign-loops=0)
-	#endif # gcc-4.0 and older
+	OPTIMIZATION+=$(call check_cc,$(CC),-falign-functions=1 -falign-jumps=1 -falign-loops=1, -malign-functions=0 -malign-jumps=0 -malign-loops=0,)
+
+	# gcc 4.1 produces many broken, totally invalid warnings
+	CHECKED_CFLAGS+=$(call check_cc,$(CC),-Werror,)
+	endif # gcc-4.0 and older

	# gcc-4.1 and beyond seem to benefit from these
	ifeq ($(strip $(shell [ $(CC_MAJOR) -ge 4 -a $(CC_MINOR) -ge 1 ] ; echo $$?)),0)