53d57dbe6

Mike Frysinger

2006-02-03

SOURCE BUG Duration: 2s

Subject

gavinl writes in Bug 661: if read() file return less than 1, we should close the fd and then goto end.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Debian 14.2.0-19) 14.2.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/mdev.c +1 -1

util-linux/mdev.c+1 -1

@@ -42,8 +42,8 @@ static void make_device(char *path)
	snprintf(temp, PATH_MAX, "%s/dev", path);
	fd = open(temp, O_RDONLY);
	len = read(fd, temp, PATH_MAX-1);
-	if (len<1) goto end;
	close(fd);
+	if (len<1) goto end;

	/* Determine device name, type, major and minor */