57f49d318
Russ Dill
2004-05-19
Subject
fix memory leak caused by switch to vfork
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
networking/udhcp/script.c+4 -3
| @@ -206,21 +206,22 @@ static char **fill_envp(struct dhcpMessage *packet) | |
| void run_script(struct dhcpMessage *packet, const char *name) | |
| { | |
| int pid; | |
| - | char **envp; |
| + | char **envp, **curr; |
| if (client_config.script == NULL) | |
| return; | |
| DEBUG(LOG_INFO, "vforking and execle'ing %s", client_config.script); | |
| + | envp = fill_envp(packet); |
| /* call script */ | |
| pid = vfork(); | |
| if (pid) { | |
| waitpid(pid, NULL, 0); | |
| + | for (curr = envp; *curr; curr++) free(*curr); |
| + | free(envp); |
| return; | |
| } else if (pid == 0) { | |
| - | envp = fill_envp(packet); |
| - | |
| /* close fd's? */ | |
| /* exec script */ | |