5aabf4e41

Rob Landley

2005-12-15

SOURCE BUG Duration: 15s

Subject

Fix -g and -p options. Patch from Traceman. (I don't know who that is, it's the darn bug generator again.)

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/tftp.c +2 -3

networking/tftp.c+2 -3

@@ -511,7 +511,6 @@ int tftp_main(int argc, char **argv)
	int cmd = 0;
	int fd = -1;
	int flags = 0;
-	int opt;
	int result;
	int blocksize = TFTP_BLOCKSIZE_DEFAULT;

@@ -551,7 +550,7 @@ int tftp_main(int argc, char **argv)
	#endif


-	opt = bb_getopt_ulflags(argc, argv, GET PUT "l:r:" BS,
+	cmd = bb_getopt_ulflags(argc, argv, GET PUT "l:r:" BS,
	&localfile, &remotefile BS_ARG);
	#ifdef CONFIG_FEATURE_TFTP_BLOCKSIZE
	if(sblocksize) {
@@ -562,7 +561,7 @@ int tftp_main(int argc, char **argv)
	}
	#endif

-	cmd &= (tftp_cmd_get & tftp_cmd_put);
+	cmd &= (tftp_cmd_get \| tftp_cmd_put);
	#ifdef CONFIG_FEATURE_TFTP_GET
	if(cmd == tftp_cmd_get)
	flags = O_WRONLY \| O_CREAT \| O_TRUNC;