← Commit list

5b88a3815

Rob Landley
Rob Landley
2006-07-10
SOURCE BUG Duration: 30s

Subject

Add itoa and utoa to see what Denis Vlasenko thinks.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/xfuncs.c+50 -1
@@ -229,4 +229,53 @@ int wait4pid(int pid)
if (WIFSIGNALED(status)) return WTERMSIG(status);
return 0;
}
-#endif
+#endif
+
+#ifdef L_itoa
+// Largest 32 bit integer is -2 billion plus null terminator.
+// Int should always be 32 bits on a Unix-oid system, see
+// http://www.unix.org/whitepapers/64bit.html
+static char local_buf[12];
+
+void utoa_to_buf(unsigned n, char *buf, int buflen)
+{
+ int i, out = 0;
+ for (i=1000000000; i; i/=10) {
+ int res = n/i;
+
+ if (res || out || i == 1) {
+ out++;
+ n -= res*i;
+ *buf++ = '0' + res;
+ }
+ }
+ *buf = 0;
+}
+
+// Note: uses static buffer, calling it twice in a row will overwrite.
+
+char *utoa(unsigned n)
+{
+ utoa_to_buf(n, local_buf, sizeof(local_buf));
+
+ return local_buf;
+}
+
+void itoa_to_buf(int n, char *buf, int buflen)
+{
+ if (n<0) {
+ n = -n;
+ *buf++ = '-';
+ }
+ utoa_to_buf((unsigned)n, buf, buflen);
+}
+
+// Note: uses static buffer, calling it twice in a row will overwrite.
+
+char *itoa(int n)
+{
+ itoa_to_buf(n, local_buf, sizeof(local_buf));
+
+ return local_buf;
+}
+#endif