← Commit list

5bec08ceb

Denys Vlasenko
Denys Vlasenko
2016-02-26
SUCCESS Duration: 229s

Subject

udhcp: trivial shrink

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/udhcp/domain_codec.c+3 -4
@@ -42,7 +42,7 @@ char* FAST_FUNC dname_dec(const uint8_t *cstr, int clen, const char *pre)
*/
while (1) {
/* note: "return NULL" below are leak-safe since
- * dst isn't yet allocated */
+ * dst isn't allocated yet */
const uint8_t *c;
unsigned crtpos, retpos, depth, len;
@@ -95,9 +95,8 @@ char* FAST_FUNC dname_dec(const uint8_t *cstr, int clen, const char *pre)
if (!dst) { /* first pass? */
/* allocate dst buffer and copy pre */
unsigned plen = strlen(pre);
- ret = dst = xmalloc(plen + len);
- memcpy(dst, pre, plen);
- dst += plen;
+ ret = xmalloc(plen + len);
+ dst = stpcpy(ret, pre);
} else {
dst[len - 1] = '\0';
break;