5c0ae06ef

Bernhard Reutner-Fischer

2006-06-03

SOURCE BUG Duration: 34s

Subject

- No options should set the current system time. Shaun Jackman writes: A bug introduced in svn 11946 broke rdate. It no longer sets the current system time when no options are specified. The options have the opposite sense from what one might think, and, oddly enough, -ps is intentionally a no-op.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/rdate.c +4 -4

util-linux/rdate.c+4 -4

@@ -68,7 +68,7 @@ int rdate_main(int argc, char **argv)

	remote_time = askremotedate(argv[optind]);

-	if (flags & 1) {
+	if ((flags & 2) == 0) {
	time_t current_time;

	time(&current_time);
@@ -77,10 +77,10 @@ int rdate_main(int argc, char **argv)
	else
	if (stime(&remote_time) < 0)
	bb_perror_msg_and_die("Could not set time of day");
+	}

-	/* No need to check for the -p flag as it's the only option left */
-
-	} else printf("%s", ctime(&remote_time));
+	if ((flags & 1) == 0)
+	printf("%s", ctime(&remote_time));

	return EXIT_SUCCESS;
	}